search

Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.
https://docs.microsoft.com/en-us/cli/azure
MIT License
383 stars 1.24k forks source link

Option for using the Pivotal build server should be clarified a bit more #3028

Open sujitdmello opened 3 years ago

sujitdmello commented 3 years ago

[Enter feedback here] Under the https://docs.microsoft.com/en-us/cli/azure/ext/spring-cloud/spring-cloud/app/deployment?view=azure-cli-latest#ext_spring_cloud_az_spring_cloud_app_deployment_create-examples section, the first option (where there is no path to a JAR/ZIP package provided) can use some clarification. If you are not careful about the current folder, this command can have undesirable results:

  1. If the current folder has many sub-folders the process takes forever and consumes all the CPU on your machine as it tries to create the massive TAR ball. It is not clear if it eventually succeeds because I've eventually realized my mistake and killed the command.
  2. If the current folder has something that has few sub-folders but is not valid code, the deployment slot can become unusable and prevents further deployments unless it is deleted.

The ask to put some warning/awareness around the current folder structure and purpose of this option. One (mistakenly) usage of this command is to create an 'empty' staging deployment slot and the workaround is to use a dummy JAR/ZIP file of an empty Spring Boot or Steeltoe application and then use the second option instead.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

yonzhan commented 3 years ago

Spring Cloud

yungezz commented 3 years ago

hi @yuwzho could you pls help to traige the issue? thanks

yuwzho commented 3 years ago

Thanks for your solid feedback, Sujit! @yucwan , I feel this is a feature ask, please take a look.