search

Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.
https://docs.microsoft.com/en-us/cli/azure
MIT License
383 stars 1.24k forks source link

AKS Periscope breaking change: Need to supply ContainerName to AKS Periscope from future release v0.5 onwards #3766

Open qpetraroia opened 3 years ago

qpetraroia commented 3 years ago

Extension name (the extension in question)

AKS Periscope

Description of issue (in as much detail as possible)

AKS Periscope used to read the container name with a hardcoded Kubeconfig. This PR and this issue discuss the breaking changes that will occur to each service that has a working contract with AKS Periscope. The removal of the hardcoded code in Periscope will allow for other tools to onboard onto AKS Periscope easily.

Azure-cli-extensions is one service that has a working contract with AKS Periscope. To keep the default behavior as it is pass the API Server Name as the ContainerName.

CC: @Tatsinnit and @sophsoph321

ghost commented 3 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/aks-pm.

Issue Details
### Extension name (the extension in question) AKS Periscope ### Description of issue (in as much detail as possible) AKS Periscope used to read the container name with a hardcoded Kubeconfig. This [PR ](https://github.com/Azure/aks-periscope/pull/96) and this [issue ](https://github.com/Azure/aks-periscope/issues/99) discuss the breaking changes that will occur to each service that has a working contract with AKS Periscope. The removal of the hardcoded code in Periscope will allow for other tools to onboard onto AKS Periscope easily. Azure-cli-extensions is one service that has a working contract with AKS Periscope. To keep the default behavior as it is pass the API Server Name as the ContainerName. ----- CC: @Tatsinnit and @sophsoph321
Author: qpetraroia
Assignees: -
Labels: `extension/aks-preview`, `AKS`, `Service Attention`
Milestone: -
yonzhan commented 3 years ago

route to service team

Tatsinnit commented 2 years ago

☕️ please note this work is merged as part of #3971 , please feel free to close this tracking issue or whenever newer version gets released. Thanks !