Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.
https://docs.microsoft.com/en-us/cli/azure
MIT License
382 stars 1.22k forks source link

Cannot run 2 instances of "az connectedk8s proxy" on the same VM #6366

Open dschveninger opened 1 year ago

dschveninger commented 1 year ago

Describe the bug

The "az connectedk8s proxy" does not allow a client proxy to run more than one instance on a VM. We would like to be able to run multiple proxies by specifying client port number.

The following code prohibit the "az connectedk8s proxy" from running multi-instances on a VM.

The code only allows a single process running:

  1. Does not allow the Client port to be set. https://github.com/Azure/azure-cli-extensions/blob/c984268f77196374baf9c058bafd957ce95ce052/src/connectedk8s/azext_connectedk8s/custom.py#L1801
  2. Check for a process name only. https://github.com/Azure/azure-cli-extensions/blob/c984268f77196374baf9c058bafd957ce95ce052/src/connectedk8s/azext_connectedk8s/_clientproxyutils.py#L125

What is the process for getting an idea like this evaluated?

Related command

None

Errors

Another instance of proxy already running

Issue script & Debug output

none

Expected behavior

Allow to specify client port and run instance of proxy on different local ports against different clusters.

Environment Summary

dschveninger@LAPTOP-GLS580EI:~/nc-scripts$ az --version azure-cli 2.39.0 *

core 2.39.0 telemetry 1.0.6

Extensions: connectedmachine 0.5.1 connectedk8s 1.3.13 azure-devops 0.25.0 k8s-extension 1.4.1 networkcloud 0.1.7.post234 customlocation 0.1.3 hybridaks 0.1.3

Dependencies: msal 1.18.0b1 azure-mgmt-resource 21.1.0b1

Python location '/opt/az/bin/python3' Extensions directory '/home/dschveninger/.azure/cliextensions'

Python (Linux) 3.10.5 (main, Jul 29 2022, 03:26:59) [GCC 9.4.0]

Legal docs and information: aka.ms/AzureCliLegal

Additional context

No response

yonzhan commented 1 year ago

Thank you for opening this issue, we will look into it.

navba-MSFT commented 1 year ago

non-customer reported. Adding Service team to look into this.

phillipleblanc commented 1 year ago

This would be very useful for us as well.

pa654321 commented 7 months ago

As an AON customer resolving this issue would be very helpful to us as well.

maroxana commented 7 months ago

Any update on this? Would be very helpful for "az connectedk8s proxy" to run multi-instances on a VM

RyanBDB commented 4 months ago

Starting with extension version 1.6.8, you should now be able to run multiple instances of az connectedk8s proxy on the same VM if you specify different ports for each. You can do this using the --port argument. Note, the proxy will also use an internal port, which will continue to use the default for the first proxy instance you create, but will then pick the port numbered 1 less than the option you specify with the --port argument for subsequent proxy instances.

Note, you will then need to set the kube context to the cluster you want to target to change which proxy is being used/ which cluster you are targeting.