update(retina): remove network observability from cli

Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.

https://docs.microsoft.com/en-us/cli/azure

MIT License

374 stars 1.16k forks source link

update(retina): remove network observability from cli #7678

Closed snguyen64 closed 4 weeks ago

snguyen64 commented 1 month ago

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

This removes network observability from the preview cli.

General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 1 month ago

❌Azure CLI Extensions Breaking Change Test

❌aks-preview

> >|rule|cmd_name|rule_message|suggest_message| >|---|---|---|---| >|❌ [1007 - ParaRemove](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1007.md) |aks create|cmd `aks create` removed parameter `enable_network_observability`|please add back parameter `enable_network_observability` for cmd `aks create`| >|❌ [1007 - ParaRemove](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1007.md) |aks update|cmd `aks update` removed parameter `disable_network_observability`|please add back parameter `disable_network_observability` for cmd `aks update`| >|❌ [1007 - ParaRemove](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1007.md) |aks update|cmd `aks update` removed parameter `enable_network_observability`|please add back parameter `enable_network_observability` for cmd `aks update`| > >

azure-client-tools-bot-prd[bot] commented 1 month ago

Hi @snguyen64, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

yonzhan commented 1 month ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 1 month ago

:warning: Release Suggestions

Module: aks-preview

:warning: Please update VERSION to be 4.0.0b6 in src/aks-preview/setup.py
Notes
Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

azclibot commented 4 weeks ago

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=163657&view=results