Containerapp job support keda msi

Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.

https://docs.microsoft.com/en-us/cli/azure

MIT License

374 stars 1.16k forks source link

Containerapp job support keda msi #7712

Closed njuCZ closed 3 weeks ago

njuCZ commented 3 weeks ago

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 3 weeks ago

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

> >|rule|cmd_name|rule_message|suggest_message| >|---|---|---|---| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|containerapp job create|cmd `containerapp job create` added parameter `scale_rule_identity`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|containerapp job update|cmd `containerapp job update` added parameter `scale_rule_identity`|| > >

azure-client-tools-bot-prd[bot] commented 3 weeks ago

Hi @njuCZ, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

yonzhan commented 3 weeks ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 3 weeks ago

:warning: Release Suggestions

Module: containerapp

Update VERSION to 1.0.0b1 in src/containerapp/setup.py
Notes
Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

Greedygre commented 3 weeks ago

Hi @njuCZ

Please fix the style issue, recently I have fix the others now it should pass.

ERROR: ************* Module azext_containerapp._params
src/containerapp/azext_containerapp/_params.py:308:90: C0303: Trailing whitespace (trailing-whitespace)