[Spring]validate path exist before all steps

Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.

https://docs.microsoft.com/en-us/cli/azure

MIT License

382 stars 1.21k forks source link

[Spring]validate path exist before all steps #7725

Closed Netyyyy closed 3 months ago

Netyyyy commented 3 months ago

Verify that artifact-path and source-path exist before all steps in az spring app deploy, az spring app deployment create and az spring job deploy commands.

Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 3 months ago

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

> > >

azure-client-tools-bot-prd[bot] commented 3 months ago

Hi @Netyyyy, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

yonzhan commented 3 months ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 3 months ago

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] commented 3 months ago

For more info about extension versioning, please refer to Extension version schema

yonzhan commented 3 months ago

Please fix CI issues.

Netyyyy commented 3 months ago

Please fix CI issues.

Fixed

Netyyyy commented 3 months ago

@zhoxing-ms @yonzhan @yanzhudd , please help take a review, and The failed CI is warning about the original code. Let us keep this PR clean for the new feature and we commit the incremental code passed all CI check.

Netyyyy commented 3 months ago

@yanzhudd do not know why pipeline failed after updating HISTORY.md and do not have a re-run permission, please help take a look

yanzhudd commented 3 months ago

/azp run

azure-pipelines[bot] commented 3 months ago

Azure Pipelines successfully started running 2 pipeline(s).

Netyyyy commented 3 months ago

Hi @yanzhudd please help approve and merge, thanks

azclibot commented 3 months ago

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/release/_build/results?buildId=169315&view=results