AKS: Add ephemeral disk volume type and nvme perf tier support to Azure Container Storage

mukhoakash commented 3 months ago

This PR adds support to change the ephemeral disk volume type ephemeral nvme perf tier for Azure Container Storage installations on AKS cluster.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 3 months ago

⚠️Azure CLI Extensions Breaking Change Test

>

⚠️aks-preview

> >|rule|cmd_name|rule_message|suggest_message| >|---|---|---|---| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks create|cmd `aks create` added parameter `ephemeral_disk_nvme_perf_tier`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks create|cmd `aks create` added parameter `ephemeral_disk_volume_type`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks update|cmd `aks update` added parameter `ephemeral_disk_nvme_perf_tier`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks update|cmd `aks update` added parameter `ephemeral_disk_volume_type`|| > >

yonzhan commented 3 months ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 3 months ago

For more info about extension versioning, please refer to Extension version schema

yonzhan commented 3 months ago

Please fix CI issues

FumingZhang commented 3 months ago

I've fixed the common style/lint issue in aks-preview via another PR #7741, please rebase from main.

mukhoakash commented 3 months ago

Triggered live test:

test_aks_create_with_azurecontainerstorage
test_aks_update_with_azurecontainerstorage
test_aks_create_with_azurecontainerstorage_with_nodepool_name
test_aks_create_with_azurecontainerstorage_with_ephemeral_disk_parameters

mukhoakash commented 3 months ago

Triggered new live test:

test_aks_create_with_azurecontainerstorage test_aks_update_with_azurecontainerstorage test_aks_create_with_azurecontainerstorage_with_nodepool_name test_aks_create_with_azurecontainerstorage_with_ephemeral_disk_parameters

azclibot commented 3 months ago

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167719&view=results

azclibot commented 3 months ago

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167768&view=results

Azure / azure-cli-extensions