updated to 2023-08-01-preview swagger changes . perimeter access rule…

bhupeshbhatt1985 commented 1 week ago

Description: Added support for service tag based perimeter access rule. Swagger updated to 2023-08-01-preview swagger changes . a

This checklist is used to make sure that common guidelines for a pull request are followed. aaz PR: https://github.com/Azure/aaz/pull/507

Related command

General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 1 week ago

⚠️Azure CLI Extensions Breaking Change Test

>

⚠️nsp

> >|rule|cmd_name|rule_message|suggest_message| >|---|---|---|---| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|network perimeter profile access-rule create|cmd `network perimeter profile access-rule create` added parameter `service_tags`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|network perimeter profile access-rule update|cmd `network perimeter profile access-rule update` added parameter `service_tags`|| > >

azure-client-tools-bot-prd[bot] commented 1 week ago

Hi @bhupeshbhatt1985, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

yonzhan commented 1 week ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 1 week ago

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] commented 1 week ago

For more info about extension versioning, please refer to Extension version schema

AllyW commented 1 week ago

⚠️ Release Suggestions

Module: nsp

⚠️ Please update VERSION to be 1.0.0b1 in src/nsp/setup.py

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.

Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.

For more info about extension versioning, please refer to Extension version schema

@bhupeshbhatt1985 please refer to this link for correcting module version update, thanks

bhupeshbhatt1985 commented 1 week ago

⚠️ Release Suggestions

Module: nsp

⚠️ Please update VERSION to be 1.0.0b1 in src/nsp/setup.py

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.

Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.

For more info about extension versioning, please refer to Extension version schema

@bhupeshbhatt1985 please refer to this link for correcting module version update, thanks

@AllyW updated to [1.0.0b1] as per suggestion and understanding from the document. Bot has removed the block tag after that but ci failing . please review and suggest if this is correct or not.