add --ampls-resource-id and --enable-high-log-scale-mode options

Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.

https://docs.microsoft.com/en-us/cli/azure

MIT License

373 stars 1.16k forks source link

add --ampls-resource-id and --enable-high-log-scale-mode options #7754

Open ganga1980 opened 5 days ago

ganga1980 commented 5 days ago

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[x] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 5 days ago

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

> >|rule|cmd_name|rule_message|suggest_message| >|---|---|---|---| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks addon enable|cmd `aks addon enable` added parameter `ampls_resource_id`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks addon enable|cmd `aks addon enable` added parameter `enable_high_log_scale_mode`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks addon update|cmd `aks addon update` added parameter `ampls_resource_id`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks addon update|cmd `aks addon update` added parameter `enable_high_log_scale_mode`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks create|cmd `aks create` added parameter `ampls_resource_id`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks create|cmd `aks create` added parameter `enable_high_log_scale_mode`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks enable-addons|cmd `aks enable-addons` added parameter `ampls_resource_id`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|aks enable-addons|cmd `aks enable-addons` added parameter `enable_high_log_scale_mode`|| > >

yonzhan commented 5 days ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 5 days ago

:warning: Release Suggestions

Module: aks-preview

Update VERSION to 5.0.0b4 in src/aks-preview/setup.py
Notes
Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

yanzhudd commented 2 days ago

please fix the CI issues

ganga1980 commented 2 days ago

Hi, @yanzhudd , @FumingZhang - CI test failures not to related to this PR and CI test failures related to this test "FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_create_with_pod_ip_allocation_mode_static_block" and I see same CI tests failures in other PRs also.

FumingZhang commented 2 days ago

/azp run

azure-pipelines[bot] commented 2 days ago

Azure Pipelines successfully started running 2 pipeline(s).