Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.
https://docs.microsoft.com/en-us/cli/azure
MIT License
373 stars 1.16k forks source link

Upgrading mdp extension to latest version and supporting new commands #7760

Open ajaykn opened 2 days ago

ajaykn commented 2 days ago

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Command: az mdp

We have latest version of mdp "Microsoft.DevOpsInfrastructure" Resource provider api to 2024-04-04-preview

https://github.com/Azure/azure-rest-api-specs/tree/main/specification/devopsinfrastructure/resource-manager/Microsoft.DevOpsInfrastructure/preview/2024-04-04-preview

As part of this PR, we upgrade the commands to latest version and support the new commands New commands are

Related PR in aaz models: https://github.com/Azure/aaz/pull/511

General Guidelines

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 2 days ago
❌Azure CLI Extensions Breaking Change Test >
> ❌mdp > >|rule|cmd_name|rule_message|suggest_message| >|---|---|---|---| >|❌ [1007 - ParaRemove](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1007.md) |mdp pool create|cmd `mdp pool create` removed parameter `provisioning_state`|please add back parameter `provisioning_state` for cmd `mdp pool create`| >|⚠️ [1011 - SubgroupAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1011.md)|mdp pool agent|sub group `mdp pool agent` added|| >|⚠️ [1010 - ParaPropUpdate](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1010.md)|mdp pool create|cmd `mdp pool create` update parameter `dev_center_project_resource_id`: updated property `name` from `dev_center_project_resource_id` to `devcenter_project_resource_id`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|mdp pool update|cmd `mdp pool update` added parameter `agent_profile`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|mdp pool update|cmd `mdp pool update` added parameter `devcenter_project_resource_id`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|mdp pool update|cmd `mdp pool update` added parameter `fabric_profile`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|mdp pool update|cmd `mdp pool update` added parameter `maximum_concurrency`|| >|⚠️ [1006 - ParaAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1006.md)|mdp pool update|cmd `mdp pool update` added parameter `organization_profile`|| >|⚠️ [1011 - SubgroupAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1011.md)|mdp sku|sub group `mdp sku` added|| >|⚠️ [1011 - SubgroupAdd](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1011.md)|mdp usage|sub group `mdp usage` added|| > >
azure-client-tools-bot-prd[bot] commented 2 days ago

Hi @ajaykn, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

yonzhan commented 2 days ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 2 days ago

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] commented 2 days ago

For more info about extension versioning, please refer to Extension version schema

ajaykn commented 2 days ago

❌Azure CLI Extensions Breaking Change Test

❌mdp

1007 - ParaRemove mdp pool create cmd mdp pool create removed parameter provisioning_state please add back parameter provisioning_state for cmd mdp pool create

This is fine, since it was a bug in older version. we dont support this parameter in creation flow.