Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.
https://docs.microsoft.com/en-us/cli/azure
MIT License
375 stars 1.16k forks source link

chore: do not use network_plugin default from sdk #7766

Open tyler-lloyd opened 1 week ago

tyler-lloyd commented 1 week ago

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

the cli should not set network_plugin defaults. it should let the AKS RP handle defaulting.

General Guidelines

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 1 week ago
️✔️Azure CLI Extensions Breaking Change Test >
> ️✔️Non Breaking Changes > > >
azure-client-tools-bot-prd[bot] commented 1 week ago

Hi @tyler-lloyd, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd[bot] commented 1 week ago

Hi @tyler-lloyd, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan commented 1 week ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 1 week ago

:warning: Release Suggestions

Module: aks-preview

FumingZhang commented 6 days ago

Failures in the CI check are not related to the change, will fix in another PR #7775

FumingZhang commented 6 days ago

7775 merged, please rebase from main

tyler-lloyd commented 1 day ago

@FumingZhang - looks like CI is passing now. thanks for the fix.

tyler-lloyd commented 10 hours ago

@zhoxing-ms PTAL