Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.
https://docs.microsoft.com/en-us/cli/azure
MIT License
382 stars 1.22k forks source link

Feature accessrule servicetag changes #7769

Closed bhupeshbhatt1985 closed 3 months ago

bhupeshbhatt1985 commented 3 months ago

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 3 months ago
️✔️Azure CLI Extensions Breaking Change Test >
> ️✔️Non Breaking Changes > > >
azure-client-tools-bot-prd[bot] commented 3 months ago

Hi @bhupeshbhatt1985, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd[bot] commented 3 months ago

Hi @bhupeshbhatt1985, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan commented 3 months ago

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions[bot] commented 3 months ago

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] commented 3 months ago

:warning: Release Suggestions

Module: nsp

bhupeshbhatt1985 commented 3 months ago

@kaushal087 please review this. please dont release it until reviewed by Kaushal

kaushal087 commented 3 months ago

@bhupeshbhatt1985 Looks good to me.

yonzhan commented 3 months ago

Please fix CI issues

azclibot commented 3 months ago

[Release] Update index.json for extension [ nsp ] : https://dev.azure.com/azclitools/release/_build/results?buildId=169923&view=results