Azure / azure-cli-extensions

Public Repository for Extensions of Azure CLI.
https://docs.microsoft.com/en-us/cli/azure
MIT License
382 stars 1.22k forks source link

[SCVMM] Add support for latest API version #7778

Closed sidsinghms closed 2 months ago

sidsinghms commented 3 months ago

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az scvmm --help

General Guidelines

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd[bot] commented 3 months ago
⚠️Azure CLI Extensions Breaking Change Test >
> ⚠️scvmm > >|rule|cmd_name|rule_message|suggest_message| >|---|---|---|---| >|⚠️ [1010 - ParaPropUpdate](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1010.md)|scvmm vm disk add|cmd `scvmm vm disk add` update parameter `vhd_type`: updated property `choices` from `['Dynamic', 'Static']` to `['Dynamic', 'Fixed']`|| >|⚠️ [1010 - ParaPropUpdate](https://github.com/Azure/azure-cli/blob/dev/doc/breaking_change_rules/1010.md)|scvmm vm disk update|cmd `scvmm vm disk update` update parameter `vhd_type`: updated property `choices` from `['Dynamic', 'Static']` to `['Dynamic', 'Fixed']`|| > >
azure-client-tools-bot-prd[bot] commented 3 months ago

Hi @sidsinghms, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd[bot] commented 3 months ago

Hi @sidsinghms, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan commented 3 months ago

SCVMM

github-actions[bot] commented 3 months ago

For more info about extension versioning, please refer to Extension version schema

sidsinghms commented 2 months ago

Hi @sidsinghms, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Sure.

yonzhan commented 2 months ago

Please fix CI issues

AllyW commented 2 months ago

⚠️Azure CLI Extensions Breaking Change Test

⚠️scvmm

rule cmd_name rule_message suggest_message

⚠️ 1010 - ParaPropUpdate scvmm vm disk add cmd scvmm vm disk add update parameter vhd_type: updated property choices from ['Dynamic', 'Static'] to ['Dynamic', 'Fixed']

⚠️ 1010 - ParaPropUpdate scvmm vm disk update cmd scvmm vm disk update update parameter vhd_type: updated property choices from ['Dynamic', 'Static'] to ['Dynamic', 'Fixed']

@sidsinghms cmd arg property update count as interface change and please update version to be 1.1.0

sidsinghms commented 2 months ago

Please fix CI issues

addressed👍

sidsinghms commented 2 months ago

@yonzhan / @AllyW I have addressed pipeline failures and updated the versioning.

Looking for the review and closure of this PR. Kindly let me know If you need anything else from me.

kairu-ms commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 2 pipeline(s).
sidsinghms commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago
Commenter does not have sufficient privileges for PR 7778 in repo Azure/azure-cli-extensions
kairu-ms commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 2 pipeline(s).
azclibot commented 2 months ago

[Release] Update index.json for extension [ scvmm ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177803&view=results