search

Azure / azure-cli

Azure Command-Line Interface
MIT License
3.97k stars 2.94k forks source link

Azure CLI support for GeoMatch WAF custom rules #12253

Closed winthrop28 closed 4 years ago

winthrop28 commented 4 years ago

Resource Provider Network

Description of Feature or Work Requested Adding GeoMatch as an operator for custom rules to allow/block by country code.

Minimum API Version Required 2019-09-01

Swagger Link App GW:https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/applicationGateway.json WAF Policies: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/webapplicationfirewall.json

Target Date March 1st

mmyyrroonn commented 4 years ago

@winthrop28 Hello. Could you give the PR link. If we already have PS cmdlet, it's nice to have it too.

yonzhan commented 4 years ago

add to S167.

winthrop28 commented 4 years ago

Here is the concept article and the powershell how-to guide. https://docs.microsoft.com/en-us/azure/web-application-firewall/ag/geomatch-custom-rules https://docs.microsoft.com/en-us/azure/web-application-firewall/ag/configure-waf-custom-rules

It's just another type of custom rule.

mmyyrroonn commented 4 years ago

@winthrop28 Hi. If I understand correctly, we just need support another type of operator in condition. Since there is not any new api and definition. It should be supported already. image Could you confirm that?

mmyyrroonn commented 4 years ago

close this issue since it's already supported.