search

Azure / azure-cli

Azure Command-Line Interface
MIT License
4.03k stars 3k forks source link

Please update docs for network firewall policy rule update to reflect correct protocols #19310

Open lluuiissoo opened 3 years ago

lluuiissoo commented 3 years ago

Hello,

I recently found an issue with the docs on this page: https://docs.microsoft.com/en-us/cli/azure/network/firewall/policy/rule-collection-group/collection/rule?view=azure-cli-latest#az_network_firewall_policy_rule_collection_group_collection_rule_update

--protocols Space-separated list of protocols and port numbers to use, in PROTOCOL=PORT format. Valid protocols are Http, Https. --remove

In the portal, in addition to Http and Https it is possible (and needed) to add Mssql as a valid protocol to a Firewall Policy Rule Collection.

Despite the documentation, I ran the command including Mssql protocol and it worked. az network firewall policy rule-collection-group collection rule update --collection-name MyCollection --name AllowAKSMicrosoft --policy-name MyPolicyName --rcg-name DefaultApplicationRuleCollectionGroup --resource-group MyResourceGroup --protocols Https=443 Mssql=1433

However, the corresponding Terraform module in azurerm provider only accepts Http and Https.

Request is to review and update the docs, so that Terraform implementation can match it.

Hope it helps,

Best regards,

-Luis

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

yonzhan commented 3 years ago

@kairu-ms for awareness