search

Azure / azure-cli

Azure Command-Line Interface
MIT License
3.91k stars 2.87k forks source link

az logic workflow update cmd without --definition option removes parameters property in Logic App code #22071

Open ShingoHanai opened 2 years ago

ShingoHanai commented 2 years ago

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug After executing following cmd, parameters property including API connection resource id in Logic App code would be removed. --- az logic workflow update --resource-group "{Resource Group}" --name "{Workflow Name}" --state "{Enabled or Disabled}" ---

To Reproduce I reproduced via latest az logic app module.

My Repro

{ "definition": { "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#", "actions": { "Get_blobcontent(V2)": { "inputs": { "host": { "connection": { "name": "@parameters('$connections')['azureblob_2']['connectionId']" } }, "method": "get", "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('AccountNameFromSettings'))}/files/@{encodeURIComponent(encodeURIComponent('JTJmdGVzdCUyZmFhYS50eHQ='))}/content", "queries": { "inferContentType": true } }, "metadata": { "JTJmdGVzdCUyZmFhYS50eHQ=": "/test/aaa.txt" }, "runAfter": {}, "type": "ApiConnection" } }, "contentVersion": "1.0.0.0", "outputs": {}, "parameters": { "$connections": { "defaultValue": {}, "type": "Object" } }, "triggers": { "Recurrence": { "evaluatedRecurrence": { "frequency": "Month", "interval": 3 }, "recurrence": { "frequency": "Month", "interval": 3 }, "type": "Recurrence" } } }, "parameters": { "$connections": { "value": { "azureblob_2": { "connectionId": "/subscriptions/subscriptionId/resourceGroups/logicapps/providers/Microsoft.Web/connections/azureblob-5", "connectionName": "azureblob-5", "id": "/subscriptions/subscriptionId/providers/Microsoft.Web/locations/japaneast/managedApis/azureblob" } } } } }

{ "definition": { "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#", "actions": { "Get_blobcontent(V2)": { "inputs": { "host": { "connection": { "name": "@parameters('$connections')['azureblob_2']['connectionId']" } }, "method": "get", "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('AccountNameFromSettings'))}/files/@{encodeURIComponent(encodeURIComponent('JTJmdGVzdCUyZmFhYS50eHQ='))}/content", "queries": { "inferContentType": true } }, "metadata": { "JTJmdGVzdCUyZmFhYS50eHQ=": "/test/aaa.txt" }, "runAfter": {}, "type": "ApiConnection" } }, "contentVersion": "1.0.0.0", "outputs": {}, "parameters": { "$connections": { "defaultValue": {}, "type": "Object" } }, "triggers": { "Recurrence": { "evaluatedRecurrence": { "frequency": "Month", "interval": 3 }, "recurrence": { "frequency": "Month", "interval": 3 }, "type": "Recurrence" } } }, "parameters": {} }

Expected behavior There expected to be no change parameters property in Logic App code.

Environment summary All Consumption Logic App has API connection.

Additional context The parameters property has data of API connection. This impact is very large.

yonzhan commented 2 years ago

route to CXP team

SaurabhSharma-MSFT commented 2 years ago

@ShingoHanai I could see the same behavior and checking internally on the same. I will get back to you.

Thanks Saurabh

ShingoHanai commented 2 years ago

@SaurabhSharma-MSFT Thanks for your quick check. Can you share ETA to fix it?

Thanks Shingo Hanai

SaurabhSharma-MSFT commented 2 years ago

@ShingoHanai I do not have any ETA as products team needs to look into this issue.

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @antcp, @AzureAppServiceCLI.

Issue Details
> ### `az feedback` auto-generates most of the information requested below, as of CLI version 2.0.62 **Describe the bug** After executing following cmd, parameters property including API connection resource id in Logic App code would be removed. *---* az logic workflow update --resource-group "{Resource Group}" --name "{Workflow Name}" --state "{Enabled or Disabled}" *---* **To Reproduce** I reproduced via latest az logic app module. My Repro - Cmd az logic workflow update --resource-group "logicapps" --name "array" --state "Enabled" - Code before executing the cmd ![image](https://user-images.githubusercontent.com/66820701/163495278-1d40eb2a-cfe2-4f93-a177-e2e44be8c912.png) { "definition": { "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#", "actions": { "Get_blob_content_(V2)": { "inputs": { "host": { "connection": { "name": "@parameters('$connections')['azureblob_2']['connectionId']" } }, "method": "get", "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('AccountNameFromSettings'))}/files/@{encodeURIComponent(encodeURIComponent('JTJmdGVzdCUyZmFhYS50eHQ='))}/content", "queries": { "inferContentType": true } }, "metadata": { "JTJmdGVzdCUyZmFhYS50eHQ=": "/test/aaa.txt" }, "runAfter": {}, "type": "ApiConnection" } }, "contentVersion": "1.0.0.0", "outputs": {}, "parameters": { "$connections": { "defaultValue": {}, "type": "Object" } }, "triggers": { "Recurrence": { "evaluatedRecurrence": { "frequency": "Month", "interval": 3 }, "recurrence": { "frequency": "Month", "interval": 3 }, "type": "Recurrence" } } }, "parameters": { "$connections": { "value": { "azureblob_2": { "connectionId": "/subscriptions/subscriptionId/resourceGroups/logicapps/providers/Microsoft.Web/connections/azureblob-5", "connectionName": "azureblob-5", "id": "/subscriptions/subscriptionId/providers/Microsoft.Web/locations/japaneast/managedApis/azureblob" } } } } } - Code after executing the cmd ![image](https://user-images.githubusercontent.com/66820701/163495419-8ffb10b6-760a-4d0a-944b-84de6ff95511.png) { "definition": { "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#", "actions": { "Get_blob_content_(V2)": { "inputs": { "host": { "connection": { "name": "@parameters('$connections')['azureblob_2']['connectionId']" } }, "method": "get", "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('AccountNameFromSettings'))}/files/@{encodeURIComponent(encodeURIComponent('JTJmdGVzdCUyZmFhYS50eHQ='))}/content", "queries": { "inferContentType": true } }, "metadata": { "JTJmdGVzdCUyZmFhYS50eHQ=": "/test/aaa.txt" }, "runAfter": {}, "type": "ApiConnection" } }, "contentVersion": "1.0.0.0", "outputs": {}, "parameters": { "$connections": { "defaultValue": {}, "type": "Object" } }, "triggers": { "Recurrence": { "evaluatedRecurrence": { "frequency": "Month", "interval": 3 }, "recurrence": { "frequency": "Month", "interval": 3 }, "type": "Recurrence" } } }, "parameters": {} } **Expected behavior** There expected to be no change parameters property in Logic App code. **Environment summary** All Consumption Logic App has API connection. **Additional context** The parameters property has data of API connection. This impact is very large.
Author: ShingoHanai
Assignees: SaurabhSharma-MSFT
Labels: `Service Attention`, `App Services`, `Logic App`, `customer-reported`, `Auto-Assign`
Milestone: -
ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-logicapps-team.

Issue Details
> ### `az feedback` auto-generates most of the information requested below, as of CLI version 2.0.62 **Describe the bug** After executing following cmd, parameters property including API connection resource id in Logic App code would be removed. *---* az logic workflow update --resource-group "{Resource Group}" --name "{Workflow Name}" --state "{Enabled or Disabled}" *---* **To Reproduce** I reproduced via latest az logic app module. My Repro - Cmd az logic workflow update --resource-group "logicapps" --name "array" --state "Enabled" - Code before executing the cmd ![image](https://user-images.githubusercontent.com/66820701/163495278-1d40eb2a-cfe2-4f93-a177-e2e44be8c912.png) { "definition": { "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#", "actions": { "Get_blob_content_(V2)": { "inputs": { "host": { "connection": { "name": "@parameters('$connections')['azureblob_2']['connectionId']" } }, "method": "get", "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('AccountNameFromSettings'))}/files/@{encodeURIComponent(encodeURIComponent('JTJmdGVzdCUyZmFhYS50eHQ='))}/content", "queries": { "inferContentType": true } }, "metadata": { "JTJmdGVzdCUyZmFhYS50eHQ=": "/test/aaa.txt" }, "runAfter": {}, "type": "ApiConnection" } }, "contentVersion": "1.0.0.0", "outputs": {}, "parameters": { "$connections": { "defaultValue": {}, "type": "Object" } }, "triggers": { "Recurrence": { "evaluatedRecurrence": { "frequency": "Month", "interval": 3 }, "recurrence": { "frequency": "Month", "interval": 3 }, "type": "Recurrence" } } }, "parameters": { "$connections": { "value": { "azureblob_2": { "connectionId": "/subscriptions/subscriptionId/resourceGroups/logicapps/providers/Microsoft.Web/connections/azureblob-5", "connectionName": "azureblob-5", "id": "/subscriptions/subscriptionId/providers/Microsoft.Web/locations/japaneast/managedApis/azureblob" } } } } } - Code after executing the cmd ![image](https://user-images.githubusercontent.com/66820701/163495419-8ffb10b6-760a-4d0a-944b-84de6ff95511.png) { "definition": { "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#", "actions": { "Get_blob_content_(V2)": { "inputs": { "host": { "connection": { "name": "@parameters('$connections')['azureblob_2']['connectionId']" } }, "method": "get", "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('AccountNameFromSettings'))}/files/@{encodeURIComponent(encodeURIComponent('JTJmdGVzdCUyZmFhYS50eHQ='))}/content", "queries": { "inferContentType": true } }, "metadata": { "JTJmdGVzdCUyZmFhYS50eHQ=": "/test/aaa.txt" }, "runAfter": {}, "type": "ApiConnection" } }, "contentVersion": "1.0.0.0", "outputs": {}, "parameters": { "$connections": { "defaultValue": {}, "type": "Object" } }, "triggers": { "Recurrence": { "evaluatedRecurrence": { "frequency": "Month", "interval": 3 }, "recurrence": { "frequency": "Month", "interval": 3 }, "type": "Recurrence" } } }, "parameters": {} } **Expected behavior** There expected to be no change parameters property in Logic App code. **Environment summary** All Consumption Logic App has API connection. **Additional context** The parameters property has data of API connection. This impact is very large.
Author: ShingoHanai
Assignees: SaurabhSharma-MSFT
Labels: `Service Attention`, `Logic App`, `customer-reported`, `Auto-Assign`
Milestone: -
ghost commented 7 months ago

I have recently reproduced this event with other subscriptions. Is there any progress here?

Best Regards,