Azure / azure-cli

Azure Command-Line Interface
MIT License
3.99k stars 2.97k forks source link

Align design across client tools to avoid inconsistent for Microsoft Graph #22355

Open jiasli opened 2 years ago

jiasli commented 2 years ago

Discussion: whether to preserve deprecated AD Graph parameter names

There has been an internal discussion recently about whether we should preserve deprecated AD Graph parameter names.

Azure PowerShell's solution: Keep AD Graph parameter names

For Azure PowerShell, after the Microsoft Graph migration, it uses

For example, New-AzADApplication uses the deprecated AD Graph property name -HomePage as the official parameter name:

image

According to https://docs.microsoft.com/en-us/graph/migrate-azure-ad-graph-property-differences, homepage has been replaced by web/homePageUrl in Microsoft Graph:

image

The new corresponding parameter name should be -WebHomePageUrl, but -WebHomePageUrl is used as an alias, instead of the official name. Other parameters face similar problems:

Problems

Azure CLI's solution: be consistent with new Microsoft Graph API

Currently, as detailed in https://docs.microsoft.com/cli/azure/microsoft-graph-migration, we decide to replace deprecated AD Graph parameter names with new Microsoft Graph ones, such as

--homepage argument is replaced by --web-home-page-url

If you have any feedback, please feel free to left a comment in this issue.

Originally posted by @jiasli in https://github.com/Azure/azure-cli/issues/12946#issuecomment-1058796773

yonzhan commented 2 years ago

Microsoft Graph solution