Azure / azure-cli

Azure Command-Line Interface
MIT License
3.96k stars 2.94k forks source link

Move to cryptography and drop pyOpenSSL dependency #29455

Open jiasli opened 1 month ago

jiasli commented 1 month ago

Per https://pypi.org/project/pyOpenSSL/

Note: The Python Cryptographic Authority strongly suggests the use of pyca/cryptography where possible. If you are using pyOpenSSL for anything other than making a TLS connection you should move to cryptography and drop your pyOpenSSL dependency.

pyOpenSSL is still widely used in Azure CLI's command modules, such as role and keyvault:

https://github.com/Azure/azure-cli/blob/38eaebb6936a32be13e2c4afba8e600ce9c91513/src/azure-cli/azure/cli/command_modules/role/custom.py#L1376

https://github.com/Azure/azure-cli/blob/a7a886923fee1ec761262b583c6640cca8a3dc5c/src/azure-cli/azure/cli/command_modules/keyvault/_validators.py#L714

yonzhan commented 1 month ago

Thank you for opening this issue, we will look into it.