Azure / azure-cli

Azure Command-Line Interface
MIT License
4.03k stars 3.01k forks source link

Azure Firewall Packet Capture Feature Support #29905

Open nikhilpadhye1 opened 2 months ago

nikhilpadhye1 commented 2 months ago

Related command

Is your feature request related to a problem? Please describe. The feature request is for a newly added azure firewall feature to take packet captures for customers as a trouble shooting tool. The support is present for powershell/swagger and rest calls but for GA we are required to support CLI as well

Describe the solution you'd like We would like to follow the same design as the powershell commands used to trigger a packet capture. Attaching a link to the packet capture commands and the swagger spec for more context.

The support will be to create packet capture filters, create packet capture parameters and invoke a packet capture using CLI similar to what is supported in powershell.

CmdLet Review PR:

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1386

Powershell PRs:

Adding support for AzureFirewallPacketCapture in powershell by nikhilpadhye1 · Pull Request #24003 · Azure/azure-powershell (github.com)

fixing packet capture call to be async by nikhilpadhye1 · Pull Request #25888 · Azure/azure-powershell (github.com)

Swagger PRs:

https://github.com/Azure/azure-rest-api-specs/pull/23114

Moving missed changes from 2023-11-01 packet capture swagger fix to l… by nikhilpadhye1 · Pull Request #29473 · Azure/azure-rest-api-specs (github.com)

Describe alternatives you've considered N/A - this is a requirement for GA of the packet capture feature for azure firewall.

Additional context Was asked to create this request after creating an email thread as seen in the screenshot below.

yonzhan commented 2 months ago

Thank you for opening this issue, we will look into it.

nikhilpadhye1 commented 2 months ago

email sent:

image