search

Azure / azure-cli

Azure Command-Line Interface
MIT License
3.98k stars 2.96k forks source link

Official Docker Image based on Ubuntu #9636

Open zikalino opened 5 years ago

zikalino commented 5 years ago

Is your feature request related to a problem? Please describe. Current official Docker image is based on Alpine:

https://github.com/Azure/azure-cli/blob/dev/Dockerfile

I think at some point it would be good to have official image that can be used by Visual Studio Code Remote - Containers. https://code.visualstudio.com/docs/remote/containers

Unfortunately:

"Note: Alpine Linux and Windows based dev containers are not currently supported."

Describe the solution you'd like Perhaps it would make sense to have Ubuntu based container as well?

Describe alternatives you've considered I was testing this scenario with Dockerfile included in .devcontainer, however this solution is pretty inefficient. Having official developers container would be really useful. Perhaps Dockerfile should be in azure-cli-dev-tools though.

Additional context

marstr commented 5 years ago

This is something I've kicked around for a while! I think it's a great idea. You can see a little conversation about this here: https://github.com/Azure/azure-cli/pull/8430

Basically what it comes down to, is that you already have a great place to start with ${repo_root}/scripts/release/debian/Dockerfile. The last container is called execution-env and only contains what is necessary to run the CLI. If you add the other utilities that are currently in the alpine image (like JP), I think we'd be good to go.

yonzhan commented 4 years ago

add to S163.

dejoost commented 3 years ago

we have a cicd using a sidecar injecting stuff in a main build container, for some steps we only need azure-cli to be there. Major drawback: we have to roll our own since alpine is lacking some features.

I'm also wondering why azure-cli has alpine and only alpine, most of the MS related tools use a debian based image by default

ggirard07 commented 3 years ago

Also to add to the issue, this currently seems to prevent using the image in an Azure Devops pipeline, for example when running on a self hosted agent where azure-cli is not preinstalled on it like hosted agents. https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=azure-devops#add-requirements