search

Azure / azure-cosmos-dotnet-v3

.NET SDK for Azure Cosmos DB for the core SQL API
MIT License
741 stars 494 forks source link

[ClientTelemetry] Client telemetry tests are flaky #4731

Closed neildsh closed 1 month ago

neildsh commented 1 month ago

ClientTelemetryTestsBase has logic that is timing dependent. This causes the tests to be flaky. The test also appears to be making real network requests, presumably to a server outside the node that tests run on. Ideally, the WaitAndAssert method should be rewritten to correct these deficiencies.

To Reproduce This reproduces in the PR builds.

Expected behavior Tests should not use calls to Task.Delay or make network requests outside the node that they run on. The outcome of a test should be deterministic.

kirankumarkolli commented 1 month ago

@sourabh1007 can you please take a look?

Pilchie commented 1 month ago

:eyes:

Pilchie commented 1 month ago

If we can't prioritize this and identify a fix within this week, we should disable these tests until we can. It unduly impacts the productivity of the entire team.