search

Azure / azure-cosmos-table-dotnet

.NET SDK for Azure Cosmos Table API
14 stars 6 forks source link

`NameValidator` and `StorageErrorCodeStrings` missing after migrating to `Microsoft.Azure.Cosmos.Table` #5

Closed seniorquico closed 5 years ago

seniorquico commented 5 years ago

I'm working on migrating the Microsoft Orleans providers from WindowsAzure.Storage to Microsoft.Azure.Cosmos.Table. I've hit a snag with two classes that have changed visiblity. Namely, NameValidator and StorageErrorCodeStrings. These used to be public, but now they're internal. Here are examples of where they're being used (in my WIP fork/branch):

NameValidator.ValidateTableName StorageErrorCodeStrings.ResourceNotFound StorageErrorCodeStrings.OperationTimedOut

What are the recommended alternatives?

donghexu commented 5 years ago

Hi @seniorquico Thanks, I'll fix it in the next release.

ggirard07 commented 5 years ago

@donghexu same thing with TableErrorCodeStrings now being internal in Microsoft.Azure.Cosmos.Table while it is public in Microsoft.WindowsAzure.Storage.Table. Can you fix it too at the same time?

seniorquico commented 5 years ago

@donghexu Any idea when the next release will be ready?

Vhab commented 5 years ago

This is blocking us from migrating as well

donghexu commented 5 years ago

Hi All, we just release 1.0.4-preview with that fix. Please try it out. Thanks!