Azure / azure-cosmosdb-java

Java Async SDK for SQL API of Azure Cosmos DB
MIT License
54 stars 61 forks source link

Added support for accessing non partitioned collections using V3 SDK #107

Closed srinathnarayanan closed 5 years ago

srinathnarayanan commented 5 years ago

Other changes:

moderakh commented 5 years ago

PartitionKeyInternal is an internal construct in com.microsoft.azure.cosmosdb.internal.routing package which is an internal package.

This PR is making it public. The existing public methods in PartitionKeyInternal are really meant to be used internally. for example

   // PartitionKeyInternal
    public List<IPartitionKeyComponent> getComponents() {
        return this.components;
    }
moderakh commented 5 years ago

This is exposing internal API as public API @srinathnarayanan can we talk when you get a chance?

christopheranderson commented 5 years ago

@srinathnarayanan & @kushagraThapar will clean up any lingering test issues in another PR, mostly need this in for the OM changes.