search

Azure / azure-cosmosdb-java

Java Async SDK for SQL API of Azure Cosmos DB
MIT License
54 stars 61 forks source link

Implementation for Change Feed Processor #128

Closed milismsft closed 5 years ago

milismsft commented 5 years ago

Refactoring from V2 Rx based code to Reactor Flux/Mono.

This change is Reviewable

moderakh commented 5 years ago
  1. implementation doesn't use async pattern, by using block() or ExecutorService you are not using the async nature of the async sdk
  2. whoever subscribes to Flux and Mono should be able to unsubscribe using reactor stream unsubscribe/cancel https://www.reactive-streams.org/reactive-streams-1.0.2-javadoc/org/reactivestreams/Subscription.html#cancel-- why aren't we using this instead of CancellationToken defined in the code?
christopheranderson commented 5 years ago

https://github.com/Azure/azure-cosmosdb-java/issues/173 tracks some fixes we need to do before GA

christopheranderson commented 5 years ago

Created issue to track cleaning up implementation: https://github.com/Azure/azure-cosmosdb-java/issues/175