Azure / azure-databricks-operator

Kubernetes Operator for Databricks
MIT License
113 stars 48 forks source link

Pin tooling versions #166

Closed lawrencegripper closed 4 years ago

lawrencegripper commented 4 years ago

This PR pins the versions of tooling used in the devcontainer to ensure future builds of the container are reproducable.

The driver for this change was issues observed with gopls and kubectl in another project.

For kubectl v1.17 change validation behavior which introduced a breaking change when using some scripts.

For gopls the location of the files in the repo moved which caused the devcontainer to stop building correctly.

I've raised this as draft as it would be good to get #152 in first so the devcontainer changes are built before being merged.

lawrencegripper commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).
stuartleeks commented 4 years ago

@lawrencegripper - now that #152 is merged, are you ok to publish this?

lawrencegripper commented 4 years ago

Will do, let me rebase now and push

stuartleeks commented 4 years ago

Thanks @lawrencegripper - are you ok to mark as Ready for Review now?

lawrencegripper commented 4 years ago

Just testing some stuff out atm, make set-kindcluster seems to have an issue so will fix up then push. Sorry for the delay

stuartleeks commented 4 years ago

np - thanks for updating. (was just checking in case you'd made the update but not marked as ready for review.... not that I'd ever do something like that 😉)

lawrencegripper commented 4 years ago

Was an issue my side, good to go with review.

lawrencegripper commented 4 years ago

@Azadehkhojandi / @JasonTheDeveloper are you to have a review of this one? @EliiseS is working on some changes to the devcontainer for the load testing work and would be good to base them off this one.

Azadehkhojandi commented 4 years ago

/azp run