Closed lawrencegripper closed 4 years ago
/azp run
@lawrencegripper - now that #152 is merged, are you ok to publish this?
Will do, let me rebase now and push
Thanks @lawrencegripper - are you ok to mark as Ready for Review now?
Just testing some stuff out atm, make set-kindcluster
seems to have an issue so will fix up then push. Sorry for the delay
np - thanks for updating. (was just checking in case you'd made the update but not marked as ready for review.... not that I'd ever do something like that 😉)
Was an issue my side, good to go with review.
@Azadehkhojandi / @JasonTheDeveloper are you to have a review of this one? @EliiseS is working on some changes to the devcontainer for the load testing work and would be good to base them off this one.
/azp run
This PR pins the versions of tooling used in the devcontainer to ensure future builds of the container are reproducable.
The driver for this change was issues observed with
gopls
andkubectl
in another project.For
kubectl
v1.17 change validation behavior which introduced a breaking change when using some scripts.For
gopls
the location of the files in the repo moved which caused the devcontainer to stop building correctly.I've raised this as draft as it would be good to get #152 in first so the devcontainer changes are built before being merged.