Azure / azure-dev

A developer CLI that reduces the time it takes for you to get started on Azure. The Azure Developer CLI (azd) provides a set of developer-friendly commands that map to key stages in your workflow - code, build, deploy, monitor, repeat.
https://aka.ms/azd
MIT License
393 stars 187 forks source link

[Issue] runtimeName capitalization in appservice.bicep #1347

Open pamelafox opened 1 year ago

pamelafox commented 1 year ago

Describe the bug

appservice.bicep has this for runtimeName:

// Runtime Properties
@allowed([
  'dotnet', 'dotnetcore', 'dotnet-isolated', 'node', 'python', 'java', 'powershell', 'custom'
])
param runtimeName string
param runtimeNameAndVersion string = '${runtimeName}|${runtimeVersion}'
param runtimeVersion string

However, the portal produces strings that are capitalized:

Screenshot 2023-01-10 at 11 55 56 AM

I'm guessing the capitalization does not matter, I just want to confirm that since it stood out to me while porting my app over to the core modules. (I got an error when I used PYTHON as the runtime).

rajeshkamal5050 commented 1 year ago

@jongio any inputs?

jongio commented 1 year ago

The team has confirmed that these settings are not case sensitive. What error were you seeing pamela?

pamelafox commented 1 year ago

Ah the error is just from the Bicep verification stage, because core/appservice.bicep has these parameters:

@allowed([ 'dotnet', 'dotnetcore', 'dotnet-isolated', 'node', 'python', 'java', 'powershell', 'custom' ])

So it doesn't allow "PYTHON" since it's not in the list. I think that's fine, developers can just write "python" when they realize you expect lowercase.

jongio commented 1 year ago

We could consider adding the upper and lower variations to the list of allowed values.