Closed pamelafox closed 1 year ago
pamelafox
commented
1 year ago Update: I've tested with a function app with and without useApim and also tested an ACA app with and without useApim (where I would expect the setting to get ignored). Things looks good.
jongio
commented
1 year ago LGTM, @rajeshkamal5050 do we want to run automation or manual tests on this?
rajeshkamal5050
commented
1 year ago @pamelafox you can run the template tests automation pipeline with/without APIM. It should cover for any regressions. https://dev.azure.com/azure-sdk/internal/_build?definitionId=5002
@weikanglim please add if any additional testing needs to be done.
pamelafox
commented
1 year ago @rajeshkamal5050 Thanks, I'm trying to figure out how to trigger that pipeline for my branch, I haven't used ADO pipelines before and am wondering if I'm lacking permissions or just don't know what to click. Here's what I see:
I thought I'd find a manual trigger option in the branches tab, but don't see anything there or in the menu on it. Can you advise?
rajeshkamal5050
commented
1 year ago /azp run azure-dev - template - tests
azure-pipelines[bot]
commented
1 year ago pamelafox
commented
1 year ago Hm, the "install azd" task failed on that job. The output shows it trying to download from a different URL than previous jobs.
install-azd: Downloading [https://***.blob.core.windows.net/azd/standalone/pr/1403/azd-linux-amd64.tar.gz](https://%2A%2A%2A.blob.core.windows.net/azd/standalone/pr/1403/azd-linux-amd64.tar.gz) to /tmp/tmp.ilQODVfDLa
install-azd: ERROR: Could not download from [https://***.blob.core.windows.net/azd/standalone/pr/1403/azd-linux-amd64.tar.gz,](https://%2A%2A%2A.blob.core.windows.net/azd/standalone/pr/1403/azd-linux-amd64.tar.gz,) ensure platform and architecture are supportedinstall-azd: Downloading https://azure-dev.azureedge.net/azd/standalone/release/daily/azd-linux-amd64.tar.gz to /tmp/tmp.YQ2hl2Yf2S
azd-linux-amd64@danieljurek @weikanglim can you help in running the template test pipelines with/without APIM?
danieljurek
commented
1 year ago /azp run azure-dev - repoman
azure-pipelines[bot]
commented
1 year ago danieljurek
commented
1 year ago We've got two pipeline runs verifying this:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2129029&view=results -- This uses repoman to generate the PR branch in other repos for testing AND runs a plain set of template tests (no APIM).
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2129287&view=results -- Set USE_APIM=true when queuing azure-dev - template - tests and pointed to the merge commit. This enables APIM.
rajeshkamal5050
commented
1 year ago /azp run azure-dev - repoman
azure-pipelines[bot]
commented
1 year ago 
weikanglim
commented
1 year ago Running with APIM enabled: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2152232&view=results
Going to quickly verify this before merging.
weikanglim
commented
1 year ago /azp run azure-dev - repoman
azure-pipelines[bot]
commented
1 year ago pamelafox
commented
1 year ago @wbreza Not sure why I had the dependsOn originally, I sometimes put it to be better "safe than sorry" or while working around Bicep issues. However, I just tried removing it from todo-python and it seemed to deploy fine. Hopefully the template tests all pass! Thanks for the help.
weikanglim
commented
1 year ago /azp run azure-dev - repoman
azure-pipelines[bot]
commented
1 year ago 
azure-sdk
commented
1 year ago Repoman pushed changes to remotes for the following projects:
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo-aca -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-aca -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/1403View Changes | Compare Changes
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo -b pr/1403View Changes | Compare Changes
Web Apps and Functions both have an "API Management" link in the left sidebar in Azure Portal that can optionally embed a connected API Management instance.
That link is set by the apiManagementConfig property on the Web/Function app.
This PR adds that configuration to all the samples with a Web/Function App backend. The samples that use Azure Container Apps should not be affected by the change.
I have verified this works on todo-python-mongo-swa-func and will test a few others as well. I am hoping there's an automated build for all the TODO apps once I make a pull request, but that may be wishful thinking. I'll find out soon!