search

Azure / azure-dev

A developer CLI that reduces the time it takes for you to get started on Azure. The Azure Developer CLI (azd) provides a set of developer-friendly commands that map to key stages in your workflow - code, build, deploy, monitor, repeat.
https://aka.ms/azd
MIT License
396 stars 190 forks source link

core/host/functions.bicep - 'dotnetcore' is not a valid value for FUNCTIONS_WORKER_RUNTIME #2555

Open mcollier opened 1 year ago

mcollier commented 1 year ago

Output from azd version azd version 1.1.0 (commit ea9cb12575734ee6a5f99c4d415c1a51d6f32d3e)

Describe the bug https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/host/functions.bicep includes 'dotnetcore' as a possible value for the Azure Functions runtime (via the FUNCTIONS_WORKER_RUNTIME application setting).

According to https://learn.microsoft.com/en-us/azure/azure-functions/functions-app-settings#functions_worker_runtime, 'dotnetcore' is not a valid value.

Expected behavior

A new input parameter should be created which is specific to the allowed Azure Functions runtime values, and then used when setting the FUNCTIONS_WORKER_RUNTIME setting.

@allowed([
  'dotnet', 'dotnet-isolated', 'node', 'python', 'java', 'powershell', 'custom'
])
param functionsWorkerRuntime string
jongio commented 1 year ago

Just a note that we do need this setting in appservice.bicep. I understand if not a function option, but please keep in appservice.

rajeshkamal5050 commented 12 months ago

@ellismg @savannahostrowski adding it to the Germanium bucket. We can pull it into iterations/sprints as part of planning.