search

Azure / azure-dev

A developer CLI that reduces the time it takes for you to get started on Azure. The Azure Developer CLI (azd) provides a set of developer-friendly commands that map to key stages in your workflow - code, build, deploy, monitor, repeat.
https://aka.ms/azd
MIT License
404 stars 195 forks source link

Implement `RenameAspireHostAsync` RPC for Aspire Server #3283

Open ellismg opened 8 months ago

ellismg commented 8 months ago

VS Sends us a notification when the AppHost project is renamed. We should figure out what to do when this happens. One thing we can do is try to rename the value in the azure.yaml file. We'd likely need to use some of the new features of the v3 yaml package that allow us to do DOM like access do we don't lose any comments the user has.

We should also think about what, if any, caches we should invalidate when this operation happens.

weikanglim commented 8 months ago

I wonder if we're better of performing a string replacement. As a user, I certainly would want comments within azure.yaml to be updated as well.

Specifically, with YAML decoding/encoding and with yaml.v3, there are many issues dealing with unexpected whitespace/formatting diffs. This is best seen in yamlfmt's usage of yaml.v3 currently, with the list of issues captured.

rajeshkamal5050 commented 8 months ago

@ellismg @weikanglim Not in scope for VS 17.10 Preview 2. Moving it to March iteration. Feel free to pull it in, if need be.

rajeshkamal5050 commented 7 months ago

@abpiskunov @anvillan is this required for VS 17.10 Preview 3?