search

Azure / azure-dev

A developer CLI that reduces the time it takes for you to get started on Azure. The Azure Developer CLI (azd) provides a set of developer-friendly commands that map to key stages in your workflow - code, build, deploy, monitor, repeat.
https://aka.ms/azd
MIT License
404 stars 195 forks source link

Implement `StopAsync` RPC for Aspire Server #3286

Open ellismg opened 8 months ago

ellismg commented 8 months ago

We don't do anything with this RPC today. It's possible we should, perhaps like aborting all inflight connections via cancellation and then waiting for them to complete before shutting ourselves down?

Alternately, we can just have the person running us terminate the process.

When we do this, we need to think about how to implement Close for our implementation of jsonrpc2.Stream. Today it is a no-op but that also may not be correct.

We just need to think through with the VS folks what we want the shutdown behavior to be. I don't think we need to engineer anything complex to start with - but it might be nice to not worry about the server being terminated rudely.

rajeshkamal5050 commented 8 months ago

@ellismg @weikanglim Not in scope for VS 17.10 Preview 2. Moving it to March iteration. Feel free to pull it in, if need be.

rajeshkamal5050 commented 7 months ago

@abpiskunov @anvillan is this required for VS 17.10 Preview 3?

abpiskunov commented 7 months ago

I believe yes, it will be already 3rd preview and we need to wrap up all known feature gaps and leave only bug fixes for final previews before build.