Azure / azure-dev

A developer CLI that reduces the time it takes for you to get started on Azure. The Azure Developer CLI (azd) provides a set of developer-friendly commands that map to key stages in your workflow - code, build, deploy, monitor, repeat.
https://aka.ms/azd
MIT License
412 stars 201 forks source link

bicep/terraform starters containing `azure-dev.yml` workflow files #4344

Open weikanglim opened 1 month ago

weikanglim commented 1 month ago

With #4013 landed, should we remove workflows from the starters (i.e. bicep starter, terraform starter) that don't have application code in them? They should look exactly the same as what azd pipeline config would generate when it runs (we should verify if it doesn't match).

The template repositories:

There are four files under the templates/common directory I believe that could be removed with this change.

weikanglim commented 1 month ago

@jongio if this makes sense to you.

v-xuto commented 1 month ago

@rajeshkamal5050 Regarding Wei's comment above, should we wait for Jon's feedback, or should we directly submit a PR for this issue?

rajeshkamal5050 commented 1 month ago

@jongio can remove the static workflow files gives its part of azd pipeline?

rajeshkamal5050 commented 1 month ago

@v-xuto can you put out a PR for this?

v-xuto commented 1 month ago

@v-xuto can you put out a PR for this?

@rajeshkamal5050 PR is ready, please review.