Azure / azure-devops-cli-extension

Azure DevOps Extension for Azure CLI
https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/?view=azure-cli-latest
MIT License
623 stars 241 forks source link

[Bug] or [Features] az repos policy approver-count #1091

Open HenrikSommer-Energinet opened 3 years ago

HenrikSommer-Energinet commented 3 years ago

az repos policy approver-count create and update is missing the settings: image

First it prevent us from setting it from AZ CLI and if we try to update an existing policy it will reset missing settings that was set from web site or other tools.

Describe the solution you'd like

https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/repos/policy/approver-count?view=azure-cli-latest#ext_azure_devops_az_repos_policy_approver_count_create and https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/repos/policy/approver-count?view=azure-cli-latest#ext_azure_devops_az_repos_policy_approver_count_update gets a new Optional Parameters called blockLastPusherVote

Additional context It would be an idea to change the update to a PATCH request instead of a PUT. So it does not override settings az cli dont know about. Note: It require that https://docs.microsoft.com/en-us/rest/api/azure/devops/policy/configurations/update?view=azure-devops-rest-6.0 will be update to support PATCH request.

Marc013 commented 3 years ago

Is there any update on this issue? It would be great when this vital functionality would be available!

fleckert commented 1 year ago

any news? in the meantime, this might be helpful https://gist.github.com/fleckert/85129ec055a8ce0ae0f34394d1ed1067

LockTar commented 7 months ago

Any update on this?