Fix broken az devops auth

Azure / azure-devops-cli-extension

Azure DevOps Extension for Azure CLI

https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/?view=azure-cli-latest

MIT License

618 stars 240 forks source link

Fix broken az devops auth #1226

Closed roshan-sy closed 2 years ago

roshan-sy commented 2 years ago

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

[ ] : This PR has a corresponding issue open in the Repository.
[x] : Approach is signed off on the issue.

gauravsaralMs commented 2 years ago

@roshan-sy

can you take a look at this file https://github.com/Azure/azure-devops-cli-extension/blob/master/azure-devops/azext_devops/azext_metadata.json (and it's history) and see if we should update that as well ?
can you share the validation done for this pull request ?

jiasli commented 2 years ago

I don't think it is a good idea to try every Azure CLI account, as this may cause unexpected user credential to be used.

Instead, only the default/selected (subscription, tenant, user) combination should be used to get an access token. If that token doesn't have access, we should explicitly switch account with az account set.

cveld commented 2 years ago

Maybe good next time to have a good PR description. Now it is not clear to me:

What was the original problem
What is the proposed solution
What are the test cases that are run

In my case I am still not able to use AAD authentication against Azure DevOps. Using az cli 2.30.0 and devops extension 0.22. Also see https://github.com/Azure/azure-cli/issues/20529

And ensure that an issue is linked.

I just processed the instructions (https://github.com/Azure/azure-devops-cli-extension/blob/master/doc/dev_setup.md) to start developing the extension locally. And this installed version 0.23 which seems to work 🥳

jiasli commented 2 years ago

Maybe good next time to have a good PR description.

Completely agree.