search

Azure / azure-devtestlab

Azure DevTestLab artifacts, scripts and samples
MIT License
458 stars 602 forks source link

Fix ServiceFabric-LabCluster template #868

Closed Kencdk closed 1 year ago

Kencdk commented 1 year ago

The template for creating a service fabric cluster using DTL, is referencing two QuickStart arm templates. Since our templates last update, both QuickStart templates have added new required parameters, causing the template to fail.

Add the three new parameters, required when deploying a Windows cluster. Pass in the resource group location as storage location, when deploying a Linux cluster.

AaronPatterson commented 1 year ago

Should we do something to prevent this from happening again? Do we expect the quick start arm template to change again?

Kencdk commented 1 year ago

Should we do something to prevent this from happening again? Do we expect the quick start arm template to change again?

Ideally, for production workloads, a customer would copy in the bits they need - thus not using these samples but copying in the root arm templates and modify those per their needs.

It's hard to predict when/if the ServiceFabric team will update their samples - these are based on quickstart guides after all and subject to change whenever the team feels like it.