Azure / azure-diagnostics-tools

Plugins and tools for collecting, processing, managing, and visualizing diagnostics data and configuration
98 stars 92 forks source link

Logstash Eventhub input should close all connections on stop #129

Closed andrewvc closed 6 years ago

andrewvc commented 6 years ago

This plugin probably leaks connections on pipeline reload.

Consider adding

def stop
  # wait for runner threads to stop...
  @runner_threads.each(&:join)
  # free up any used resources
  #CODE TO SHUTDOWN EVENTHUB CONNECTION
end
jakelandis commented 6 years ago

logstash-input-azureeventhub has been superseded by logstash-input-azure_event_hubs

Note the options have changed and may be viewed here until they are properly added to the standard documentation.

To install the new plugin:

bin/logstash-plugin install logstash-input-azure_event_hubs

If issues are found with the new plugin please submit issues to : https://github.com/logstash-plugins/logstash-input-azure_event_hubs/issues

brahmnes commented 6 years ago

Thanks @jakelandis !