Azure / azure-documentdb-changefeedprocessor-dotnet

This library provides a host for distributing change feed events in partitioned collection across multiple observers. Instances of the host can scale up (by adding) or down (by removing) dynamically, and the load will be automatically distributed among active instances in about-equal way.
Other
51 stars 22 forks source link

Cosmos DB 2.0.0 support #96

Closed ealsur closed 6 years ago

ealsur commented 6 years ago

Cosmos DB SDK 2.0.0 changed method signatures, see https://github.com/Azure/azure-cosmosdb-dotnet/issues/578

We need to address it with a new minor version and reference updates.

jbogard commented 6 years ago

Ha I literally just hit this today with the preview build!

ealsur commented 6 years ago

@jbogard Are you referencing 2.0.0-preview or 2.0.0-preview2?

jbogard commented 6 years ago

preview2.

On Thu, Aug 30, 2018 at 5:10 AM Matias Quaranta notifications@github.com wrote:

@jbogard https://github.com/jbogard Are you referencing 2.0.0-preview or 2.0.0-preview2?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Azure/azure-documentdb-changefeedprocessor-dotnet/issues/96#issuecomment-417266857, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGYMvWRhN2ymx0qgn_bN78VOoWFyKWxks5uV7olgaJpZM4WSK65 .

kadukf commented 6 years ago

yeah, I was discussing this with Micheal last month so that we could release "preview" withi SDk2.0 preview, wdyt?

ealsur commented 6 years ago

I bumped the version to a 2.1.0-preview in the PR

kadukf commented 6 years ago

upgrading to SDK 2.0: #102

ealsur commented 6 years ago

Closing as it's solved on the latest PR merge