search

Azure / azure-event-hubs-go

Golang client library for Azure Event Hubs https://azure.microsoft.com/services/event-hubs
MIT License
88 stars 69 forks source link

chore(storage): Update azure-storage-blob-go to v0.14 #249

Closed nwillems closed 1 year ago

nwillems commented 2 years ago

When using azure-event-hubs-go in conjunction with golang-migrate, a shared dependency, relating to azure-storage-blob-go, forces one to either use an older version of golang-migrate or update azure-storage-blob-go.

This breaks builds as there are breaking changes introduced in azure-storage-blob-go.

I'm in no way sure this is the best way to accomplish this - so feel free to correct any missed parts. I will update the PR with tests and changelog.

Thanks in advance.

Environment

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

nwillems commented 2 years ago

As noted by the build this also puts a requirement on using go 1.16 or above, I'm not sure if this is acceptable for this library?

nwillems commented 2 years ago

WARNING - this does not work.

I've now struggled with this for a while. essentially, the changes to azblob seems to not work. hence leases aren't created and no events are processed.

biggest problem right now is, it is not obvious how to use the azblob client without the client provided keys, to me at least.

any insights are greatly welcome, and I'll happily drive this PR home. Right now the solution for me has been to accept an older version of go-migrate :-(