search

Azure / azure-event-hubs-go

Golang client library for Azure Event Hubs https://azure.microsoft.com/services/event-hubs
MIT License
88 stars 69 forks source link

Fixing race condition in LeaserCheckpointer where it can fail with a ContainerAlreadyExists error #253

Closed richardpark-msft closed 2 years ago

richardpark-msft commented 2 years ago

There's a slight race condition between checking the store exists and the container being created.

We can handle it easily if we just allow ContainerAlreadyExists to be considered successful. Also, since the storage tests were failing (unrelated to my change) in race detection I also fixed that as well.

Fixes #252 Fixes #225

richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
richardpark-msft commented 2 years ago

btw, the live test run with the data race fix is here: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1534362&view=results

I'm not sure why they're not being associated with the PR itself.