search

Azure / azure-event-hubs-go

Golang client library for Azure Event Hubs https://azure.microsoft.com/services/event-hubs
MIT License
88 stars 69 forks source link

Sender interface definition of SendBatch does not match actual SendBatch implementation method header definition #256

Open burkconnor opened 2 years ago

burkconnor commented 2 years ago

Expected Behavior

The Sender interface should have the same method header definition for the SendBatch method as the implementation of the SendBatch method.

interface definition: SendBatch(ctx context.Context, iterator BatchIterator, opts ...BatchOption) error implementation definition: SendBatch(ctx context.Context, iterator BatchIterator, opts ...BatchOption) error

Actual Behavior

interface definition: SendBatch(ctx context.Context, batch *EventBatch, opts ...SendOption) error implementation definition: SendBatch(ctx context.Context, iterator BatchIterator, opts ...BatchOption) error

Environment