Azure / azure-event-hubs-go

Golang client library for Azure Event Hubs https://azure.microsoft.com/services/event-hubs
MIT License
89 stars 69 forks source link

Vendor the azblob 0.6.0 dependency so customers can upgrade to later blobs packages #262

Closed richardpark-msft closed 2 years ago

richardpark-msft commented 2 years ago

azblob@v0.6.0 is a beta dependency we use for storage checkpointing. More recent releases won't compile with our package, which means that customers that want to move forward can't.

Vendoring this dependency allows us to avoid doing that upgrade until the blob package has finalized, or until we migrate over to the latest package released in azure-sdk-for-go.

Fixes #261

richardpark-msft commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
jhendrixMSFT commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
jhendrixMSFT commented 2 years ago

/azp run Azure.azure-event-hubs-go

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
aarshshah-8 commented 2 years ago

When will this be merged in? I have an issue using an updated snowflakedb (1.6.13) which needs azure-blobs 0.14.0 but azure-events-hub still requires azure-blobs 0.6.0, any recommended work arounds for such issues which leads the issues mentioned in https://github.com/Azure/azure-event-hubs-go/issues/261

jhendrixMSFT commented 2 years ago

@aarshshah-8 sorry for the delay, this has been tagged and released

aarshshah-8 commented 2 years ago

@aarshshah-8 sorry for the delay, this has been tagged and released

No worries! Thank you for taking care of it so quick. Tested it out and it works great