Add CustomHostname connection string parameter

favoretti commented 4 years ago

Description

In a case where you need to use custom DNS name for a private EventHub endpoint and do not have the ability to setup up DNS forwarding from on-premise to Azure DNS you need to split the Endpoint namespace name from the actual hostname to connect to.

This PR introduces such an ability by adding CustomHostname ConnectionString parameter.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR.
[x] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).
[x] If applicable, the public code is properly documented.
[x] Pull request includes test coverage for the included changes.
[x] The code builds without any errors.

msftclas commented 4 years ago

All CLA requirements met.

favoretti commented 4 years ago

@JamesBirdsall Would you mind having a look please?

JamesBirdsall commented 4 years ago

This is an interesting case that we had not considered. Thank you for bringing it up! Unfortunately, this repo is retired -- the active home of this code is over at https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/eventhubs/microsoft-azure-eventhubs now. (I have a PR to update the readme here to point to there, and I apologize for not doing so earlier.) This client is also the "track 1" client, which is in the process of being superceded by the rewritten "track 2" client, which you can find at https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/eventhubs/azure-messaging-eventhubs -- you may want to make your changes in track 2 instead of track 1, but either way the central Java repo is the place to do it.

Again, I want to emphasize that this is an interesting case and I urge you to port this PR to the central repo.

Thanks!

favoretti commented 4 years ago

Dang :) Sure, no problem, I'll port this to the newer client. See you on the flipside then :) Thanks a lot for your quick response!

Azure / azure-event-hubs-java

Add CustomHostname connection string parameter #465

Description