search

Azure / azure-event-hubs-node

Node client library for Azure Event Hubs https://azure.microsoft.com/services/event-hubs
MIT License
50 stars 44 forks source link

Npm installation fails for v 0.2.4 #102

Closed arunp-motorq closed 6 years ago

arunp-motorq commented 6 years ago

Describe the bug npm install with latest version(0.2.4) fails with

Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

To Reproduce Steps to reproduce the behavior:

Package-name: azure-event-hubs | azure-event-processor-host Package-version: 0.2.4 node.js version: 8.9.4 OS name and version: Windows 10 64 Bit

amarzavery commented 6 years ago

Upon searching for the error, I found that this error is thrown due to an eslint rule config. I suspect that it is checking node_modules folder as well. Please exclude the node_modules folder from checking the eslint rules.

I installed this on a windows box and it worked fine.

D:\sdk\tmp>npm i azure-event-hubs@v0.2.4
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN tmp No description
npm WARN tmp No repository field.
npm WARN tmp No license field.

+ azure-event-hubs@0.2.4
added 74 packages from 119 contributors and audited 225 packages in 58.648s
found 0 vulnerabilities
TheGauntt commented 6 years ago

Seems to work without error just on the initial install. Subsequent calls to npm install fail

Here's a little more from my log to add to the report. In particular note:

npm ERR! prepareGitDep npm ERR! Failed at the rhea@0.2.16 lint script.
...
npm ERR! prepareGitDep   82:17   error  Expected linebreaks to be 'LF' but found 'CRLF'  linebreak-style
npm ERR! prepareGitDep   83:3    error  Expected linebreaks to be 'LF' but found 'CRLF'  linebreak-style
npm ERR! prepareGitDep
npm ERR! prepareGitDep ✖ 4811 problems (4811 errors, 0 warnings)
npm ERR! prepareGitDep   4811 errors, 0 warnings potentially fixable with the `--fix` option.
npm ERR! prepareGitDep
npm ERR! prepareGitDep
npm ERR! prepareGitDep 2> npm WARN install Usage of the `--dev` option is deprecated. Use `--only=dev` instead.
npm ERR! prepareGitDep npm WARN deprecated istanbul-lib-hook@1.2.1: 1.2.0 should have been a major version bump
npm ERR! prepareGitDep npm ERR! code ELIFECYCLE
npm ERR! prepareGitDep npm ERR! errno 1
npm ERR! prepareGitDep npm ERR! rhea@0.2.16 lint: `eslint lib/*.js`
npm ERR! prepareGitDep npm ERR! Exit status 1
npm ERR! prepareGitDep npm ERR!
npm ERR! prepareGitDep npm ERR! Failed at the rhea@0.2.16 lint script.
npm ERR! prepareGitDep npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
amarzavery commented 6 years ago

I have published a new version 0.2.5 which depends on ^0.2.16 version of rhea, rather than taking a git dependency on the package. I think this should fix the issue. Can you try installing the new version and let me know the status?

TheGauntt commented 6 years ago

@amarzavery Thanks! Works with 0.2.5