search

Azure / azure-event-hubs-node

Node client library for Azure Event Hubs https://azure.microsoft.com/services/event-hubs
MIT License
50 stars 46 forks source link

Convert the partitionKey to a type of `string`. #191

Closed ShivangiReja closed 5 years ago

ShivangiReja commented 5 years ago

Description

When users set a partitionKey, the library converts the partitionKey to a type of string.

amarzavery commented 5 years ago

OPS Build status updates of commit 0c90f64:

:clock10: Preparing: average preparing time is 1 min(s) 4 sec(s)

amarzavery commented 5 years ago

OPS Build status updates of commit 0c90f64:

:clock10: Incremental building: average incremental building time is 20 sec(s)

amarzavery commented 5 years ago

OPS Build status updates of commit 0c90f64:

:white_check_mark: Validation status: passed

File Status Preview URL Details
client/lib/eventHubSender.ts :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

amarzavery commented 5 years ago

OPS Build status updates of commit a6cd3d5:

:clock10: Preparing: average preparing time is 1 min(s) 1 sec(s)

amarzavery commented 5 years ago

OPS Build status updates of commit a6cd3d5:

:clock10: Incremental building: average incremental building time is 19 sec(s)

amarzavery commented 5 years ago

OPS Build status updates of commit a6cd3d5:

:white_check_mark: Validation status: passed

File Status Preview URL Details
client/lib/eventHubSender.ts :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

amarzavery commented 5 years ago

OPS Build status updates of commit e7cfd19:

:clock10: Preparing: average preparing time is 59 sec(s)

amarzavery commented 5 years ago

OPS Build status updates of commit e7cfd19:

:clock10: Incremental building: average incremental building time is 19 sec(s)

amarzavery commented 5 years ago

OPS Build status updates of commit e7cfd19:

:white_check_mark: Validation status: passed

File Status Preview URL Details
client/lib/eventHubSender.ts :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

jeremymeng commented 5 years ago

Note that the fix should be made in the central repo now.

ramya-rao-a commented 5 years ago

As concluded in https://github.com/Azure/azure-event-hubs-node/issues/180, lets throw an error when user passes a partitionKey which is not a string.

Closing this PR as the work needs to happen in the new repo