Azure / azure-functions-core-tools

Command line tools for Azure Functions
MIT License
1.31k stars 433 forks source link

Hot reload #1239

Open ahmedelnably opened 5 years ago

janmechtel commented 4 years ago

I'm really eager to get this. It's so nice to be able to test Functions super fast in the Azure Portal, we need that locally as well!

galgrunfeld-madtrix commented 4 years ago

So still no news on this?

janmechtel commented 4 years ago

Everyone interested in this should consider switching the language to c# script for development purposes, works like a charm: https://stackoverflow.com/questions/59783914/how-to-speed-up-debugging-c-sharp-azure-function-locally-is

galvesribeiro commented 4 years ago

@janmechtel even though it works well on C# scripts, its far from ideal because it goes against other features that we've asking so much for Az Func like pre-compiled projects, ReadyToRun (not available yet) and most important, Dependency Injection support.

Its almost one year old issue. @ahmedelnably do you have any news on whether this would be supported or not? This would REALLY streamline the support. Right now we have Collectible Assemblies support in .Net Core, so we are able to load and unload assemblies at runtime so that could be supported even if you are not using the regular watch feature from dotnet CLI.

marcin-dardzinski commented 4 years ago

In case anyone is interested, I've found a workaround. You have to create an MSBuild target which runs the functions host and watch against this target: In the csproj add

  <Target Name="RunFunctions">
    <Exec Command="func start" />
  </Target>

and later run it with dotnet watch msbuild /t:RunFunctions. So far works well for me.

seed-of-apricot commented 4 years ago

Would some workaround be on JavaScript/TypeScript environment?

hlz commented 4 years ago

I would also like to know how a hot reloaded or watched development environment can be setup in node. Any clues or leads?

MattL-NZ commented 3 years ago

Would some workaround be on JavaScript/TypeScript environment?

I would also like to know this for Typescript...

hlz commented 3 years ago

Fwiw I have found out that it is possible running func startand tsc -w in parallel under JS/TS. Changes made to function code are picked up directly by the local function host so there is no need for restarting. Except for changes in function.json files. Could elaborate more if someone finds that interesting.

grbspltt commented 3 years ago

Fwiw I have found out that it is possible running func startand tsc -w in parallel under JS/TS. Changes made to function code are picked up directly by the local function host so there is no need for restarting. Except for changes in function.json files. Could elaborate more if someone finds that interesting.

the big issue I have with this is the horrendous errors. Since its trying to run compiled JS, you're left with trying to figure out where it went wrong in TS. Would be nice to use ts-node for development

edit: Created an issue for this Azure/azure-functions-nodejs-worker#736

hlz commented 3 years ago

the big issue I have with this is the horrendous errors. Since its trying to run compiled JS, you're left with trying to figure out where it went wrong in TS. Would be nice to use ts-node for development

Yeah this is far from ideal. Same problem arises when debugging code.

edit: Created an issue for this Azure/azure-functions-nodejs-worker#736

Hope this will make it's way into the extension.

ryan-theta commented 3 years ago

Would this include live reload in Ubuntu WSL2 for the Python runtime?

KevinFerm commented 3 years ago

Hi! What's the status on this? Dotnet has this for years through dotnet watch run. Should be easy to add especially for azure functions in C#, no?

chuanqisun commented 3 years ago

Curious if this is being triaged at all. It is an obvious productivity killer. I'm using the out-of-the-box TypeScript Azure Function debug task from vscode. For every single change, I have to kill the entire running function, reinstalling npm package (why do we need this?), recompile typescript. That's 10-20 seconds gone. Please consider improving the default debug experience

panmona commented 3 years ago

@chuanqisun If you use the start script provided with func init this works out of the box with Typescript.

But maybe your problem is related to the issue I just opened: Azure/azure-functions-host#7795

chenxizhang commented 3 years ago

same issue here, let's make it fix on typescript azure function

chenxizhang commented 3 years ago

I saw that "tsc -w" is working fine, but the "func start" maybe have some problem, it just not able to detect the changes on the dist folder

Yvand commented 3 years ago

I have exactly the same behavior as @chenxizhang: When I run npm run start: tsc -w does update the files in dist folder, but func is not actually using those changes, so I have to kill the task and run npm run start again.

nerblock commented 3 years ago

I'm developing a ts api and this is driving me crazy. Please, implement this for god's sake. 🤦‍♂️

Yvand commented 3 years ago

I found how to make it work in my TypeScript project: I removed variables WEBSITE_MOUNT_ENABLED and WEBSITE_RUN_FROM_PACKAGE from my local.settings.json. Now, npm run start immediately serves the changes when I save the .ts file. Those variables were added when I executed func azure functionapp fetch-app-settings.

chenxizhang commented 3 years ago

wow, thanks to @Yvand, it works for me now. You save many time for me, man

iSeiryu commented 2 years ago

The workaround from @marcin-dardzinski is great, but is there a more native way to do it with dotnet 6? Something like dotnet watch run or func watch start?

mdddev commented 2 years ago

I second what @iSeiryu said. Afterall, hot reload was successfully kept in NET6 also for non Visual Studio users. How can this be integrated into the function core tools?

a3y3 commented 2 years ago

Agreed, this should absolutely be added as a feature (especially with Functions - 4 and/or .NET 6 projects)

CharlieDigital commented 2 years ago

@a3y3 agreed; since it works, it seems like the team should just formalize it.

mdddev commented 2 years ago

@CharlieDigital how did you get it to work with vs code? Sorry if I misunderstood.

CharlieDigital commented 2 years ago

@mdddev I used @marcin-dardzinski 's workaround as described above in this discussion.

chuanqisun commented 2 years ago

Still waiting for an official support. But for those who use Node.js runtime, here is my workaround

package.json

{
  "scripts": {
    "start": "concurrently npm:start:*",
    "start:tsc": "tsc -w --preserveWatchOutput",
    "start:func": "nodemon --watch dist --delay 1 --exec \"func start -p 7072\""
  },
  "devDependencies": {
    "concurrently": "^7.0.0",
    "nodemon": "^2.0.15",
    "typescript": "^4.5.5"
  }
}

To use breakpoint debug in VS Code, update .vscode/launch.json

{
  "version": "0.2.0",
  "configurations": [
    {
      "name": "Debug Azure Function",
      "request": "launch",
      "runtimeArgs": ["run-script", "start"],
      "runtimeVersion": "14",
      "runtimeExecutable": "npm",
      "skipFiles": ["<node_internals>/**"],
      "type": "pwa-node",
      "console": "integratedTerminal"
    }
  ]
}

Only known issue is that the function will immediate reload after initial start. And if you project depends on other files in the directory, you'd need to add new watch parameter manually. Everything else is working.

mdddev commented 2 years ago

@mdddev I used @marcin-dardzinski 's workaround as described above in this discussion.

Hi @CharlieDigital , thanks for hinting me in that direction. I tried this, however, it seems that this is only exiting the process and invoking func start automatically on a code change. I was under the assumption that hot reload injects the code changes into the running process.

CharlieDigital commented 2 years ago

@mdddev one can dream!

a3y3 commented 2 years ago

Seems like this works already out of the box on Visual Studio? Not sure how the IDE does it under the hood but it has a hot reload button that applies the current changes in less than a second.

bmind7 commented 2 years ago

For JS restart: true added to launch.json saved my day https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_restarting-debug-sessions-automatically-when-source-is-edited

safwanmasarik commented 1 year ago

Eureka. I solved it in an elegant way. Here code ref: https://github.com/safwanmasarik/Azure-Function-Typescript-Hot-Reload . Video evidence: https://user-images.githubusercontent.com/35250295/201973704-b11eeb4a-8d41-4e0b-9f9b-385fdcf10846.mp4

iljaiwjew commented 1 year ago

Any progress on this for TypeScript? It's very annoying that such basic feature doesn't work

allprogrammers commented 1 year ago

This feature is really needed

Trubador commented 1 year ago

Any update on this? Development speed is very important.

mdddev commented 1 year ago

I second this. Out-of-the-box hot reload functionality is needed. Since this by the OP is a generic Hot Reload request generic with respect to the programming language used, there seem to be mainly two sides to this converstation. The ones using Javascript/Typescript and the ones using NET/C#. While there appear to be some workarounds for Typescript, none so far have presented themselves for NET.

I this something on the roadmap of the Azure Function Core Tools? Modern Azure Functions in the isolated worker are basically a console application, for which hot reload is supported, right? Therefore I assume it is in the way the Azure Function Core Tools choose to interact with the ability (or not).

jaemsnrg commented 1 year ago

If anyone was like me and ran into the looping nodemon issue, here is a fix:

package.json: ... "start": "nodemon" ...

nodemon.json: { "watch": ["your_function_folder/"], "ext": "js,json", "ignore": ["node_modules/"], "exec": "func start --verbose --javascript -p 3030 --watch" }

rafaelgrilli92 commented 1 year ago

Still not working for TypeScript. I can't believe a simple thing like this that speeds up the development process so much is still an issue.

Crisfole commented 11 months ago

If this isn't working for you in TS you should check your RUN_FROM_PACKAGE setting. It must be falsey (0 or unset) for picking up changes to your code as they come in.

mdddev commented 10 months ago

Raising the flag for .NET here again, as most of the posts here are for Typescript. allthough the thread started with C# 😊

As far as I can tell, all IDEs except (full blown) Visual Studio rely on the Function Core Tools to manage an Azure Functions project. I have had the same Hot Reload trauma with Jetbrains Rider as I had it with VS Code. It's just not working.

I don't know how VS does it, but it seems like it does not rely on the Function Core Tools.

Is it even considere to be on the roadmap anytime soon?

Another LTS version of NET has jsut dropped, and I am always super excited about the great tooling integration of NET. Everything is faster and better than ever before. Only working with Functions feels like a road bump without a Hot Reload functionality. I'm using it (hot reload) elsewhere and it is really hard to go back, once you realise how much more productive you are with it.

subesokun commented 10 months ago

I got this working with TS and the latest Azure Function Core Tools:

With that you should be able to set breakpoints in your TS code and hot reload the function host on code changes.

mdddev commented 10 months ago

I'm glad you got this working. Although I do not understand why .NET's hot reload feature is not working with one of the supported .NET languages. I guess it might be time to abandon .NET and go with TS, since there is clearly no indication that there will be any improvements soon. Sad.

danielniccoli commented 8 months ago

Hot reloading works for me. I develop in Python with the V2 model. Have not tried any other language. When I change code, the running app takes a moment to reload and the next time I trigger a function, the updated code is used.

I noticed one thing, though. I develop in VS Code with the ms-azuretools.vscode-azurefunctions extension. It comes with some a pre-configured launch.json and tasks.json, so I just have to press F5 to start debugging. When debugging that way, hot reload does not work.

Instead, I start the host normally with func host start --language-worker -- "-m debugpy --listen 127.0.0.1:9091" and then use a custom debug config that attaches to the debugger without the shipped pre-launch tasks. Now when I change code, the function host does hot reload and I only have to re-attach the debugger.

I opened a ticket about this here: https://github.com/microsoft/vscode-azurefunctions/issues/3936

fernandorovai commented 8 months ago

Any way to ignore files on the same project to avoid hot reloading in Python?

LevYas commented 2 months ago

In case anyone is interested, I've found a workaround.

  <Target Name="RunFunctions">
    <Exec Command="func start" />
  </Target>

and later run it with dotnet watch msbuild /t:RunFunctions. So far works well for me.

Does this workaround still work on .NET 8 and in-process functions? I've just migrated to .NET 8, and func start works fine, but if I run dotnet watch -v msbuild /t:RunFunctions it fails to start:

dotnet watch ⌚ Running  with the following arguments: 'msbuild /t:RunFunctions'
dotnet watch ⌚ Error while killing process ' ': No process is associated with this object.
dotnet watch 🚀 Started
dotnet watch ❌ Application failed to start: Cannot start process because a file name has not been provided.
dotnet watch ⌚ Caught top-level exception from hot reload: System.InvalidOperationException: Cannot start process because a file name has not been provided.
   at System.Diagnostics.Process.Start()
   at Microsoft.DotNet.Watcher.Internal.ProcessRunner.RunAsync(ProcessSpec processSpec, CancellationToken cancellationToken)
   at Microsoft.DotNet.Watcher.HotReloadDotNetWatcher.WatchAsync(DotNetWatchContext context, CancellationToken cancellationToken)

I tried to understand what is the process dotnet watch complains about, but no luck.

SwenRanj commented 2 months ago

We are also facing problems with our containerized Azure Functions app in TypeScript. Any ideas on how to enable auto reloading in Docker scenario?

Our scenario is based of the hello-world-tab-docker MS teams sample. The 'api' directory contains the actual Azure Functions app.