search

Azure / azure-functions-core-tools

Command line tools for Azure Functions
MIT License
1.32k stars 433 forks source link

Allow configuration of osiris.deislabs.io/ingressHostname upon Kubernetes deployment #1310

Open rhummelmose opened 5 years ago

rhummelmose commented 5 years ago

Currently the CLI allows specifying the service type upon deployment, defaulting to LoadBalancer.

With service type LoadBalancer we'd end up with a Kubernetes provisioned Azure load balancer resource per function, which I believe in most real world cases would be undesirable.

Assuming that most users have their clusters setup with an ingress, it'd make sense to allow configuration of the osiris annotation ingressHostname, as it's required for Osiris to work if the services in question are accesses through an ingress.

Happy to provide a pull request if this makes sense to the team.

ahmedelnably commented 5 years ago

@rhummelmose, we always welcome contribution, please submit a PR and we will review it

rhummelmose commented 5 years ago

@rhummelmose, we always welcome contribution, please submit a PR and we will review it

But before I go ahead and code, can you verify whether or not you think it's an idea worth pursuing :) ?

ahmedelnably commented 5 years ago

cc @jeffhollan to comment

jeffhollan commented 5 years ago

I think this makes sense and is a great idea - and @ahmelsayed I know has been looking at improve the HTTP function story with tooling and keys

ahmelsayed commented 5 years ago

I think it makes sense too. You'll probably wanna start from here. Let me know if you have any questions.

For keys I opened a PR on the runtime here https://github.com/Azure/azure-functions-host/pull/4462