Azure / azure-functions-docker

This repo contains the base Docker images for working with azure functions
MIT License
267 stars 118 forks source link

Node PM4 is GA, but not image with correct core-tools version #1019

Open Crisfole opened 10 months ago

Crisfole commented 10 months ago

This article announced the General Availability of the node v4 programming model: https://techcommunity.microsoft.com/t5/apps-on-azure-blog/azure-functions-node-js-v4-programming-model-is-generally/ba-p/3929217

It notes that "You must be on runtime v4.25+ in Azure or core tools v4.0.5382+ if running locally to benefit from this change."

Like many, we use docker for our local development environment to avoid having to install loads of dependencies. Unfortunately the current mcr.microsoft.com/azure-functions/node:4-node18-core-tools image is behind apt, and there does not appear to be an explicit 4.0.5382 (or greater) tag in the mcr.

It's also possible I am missing something or skipping an obvious step, if so could someone help me debug my pull? I've done a docker compose down so no containers are running, and I tried docker pull mcr.microsoft.com/azure-functions/node:4-node18-core-tools, which informed me I was up to date with the remote.

Crisfole commented 10 months ago

I will add that when I copy/paste the docker file here and use that with a build for my function image (rather than the image directly): https://github.com/Azure/azure-functions-docker/blob/dev/host/4/bullseye/amd64/node/node18/node18-core-tools.Dockerfile the core version shows as

root ➜ /app $ func --version
4.0.5455

So, I believe this is just a situation where an important release has been missed?

Crisfole commented 10 months ago

After the update I show:

project-name-functions-1  | Azure Functions Core Tools
project-name-functions-1  | 
project-name-functions-1  | Core Tools Version:       4.0.5455 Commit hash: N/A  (64-bit)
project-name-functions-1  | Function Runtime Version: 4.27.5.21554

Previously it showed:


my-app-name-functions-1  | Core Tools Version:       4.0.5198 Commit hash: N/A  (64-bit)
my-app-name-functions-1  | Function Runtime Version: 4.21.1.20667```