Azure / azure-functions-dotnet-worker

Azure Functions out-of-process .NET language worker
MIT License
431 stars 184 forks source link

Types used in WorkerExtensionStartup must be public #1404

Open fabiocav opened 1 year ago

fabiocav commented 1 year ago

The registered startup types are used in code gen applied to the application project. If they're not public, that will lead to compilation errors in the target.

Two changes should be made:

1 - The source generator should only use public types. Emit a compilation warning so end users know the extension services are not being registered. 2 - An analyzer should enforce the visibility of types used with the WorkerExtensionStartupAttribute

mattchenderson commented 9 months ago

@fabiocav This was already addressed, wasn't it? Are we able to close this issue?