Tracing is broken when AspNetCore integration is used

lmolkova commented 3 days ago

Description

I configure ASP.NET Core integration along with OTel in the following way

var host = new HostBuilder()
    .ConfigureFunctionsWebApplication()
    .ConfigureServices(s => s.AddOpenTelemetry()
        .WithTracing(t => t
                .AddSource("testme")
                .AddAspNetCoreInstrumentation()
                .AddHttpClientInstrumentation())
    .UseFunctionsWorkerDefaults()
    .UseOtlpExporter())
    .Build();

and enable host telemetry with

"telemetryMode": "openTelemetry"

In my function code I create another activity

[Function("Function1")]
public async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Anonymous, "get", "post")] HttpRequestData req)
{
    using var act = test.StartActivity("THIS IS A TEST");
    _logger.LogInformation("C# HTTP trigger function processed a request.");

    var response = req.CreateResponse(HttpStatusCode.OK);
    response.Headers.Add("Content-Type", "text/plain; charset=utf-8");

    await response.WriteStringAsync("Welcome to Azure Functions!");

    return response;
}

What I get:

I.e.

GET - incoming HTTP request to host
- GET - outgoing HTTP request from host to worker
  - TestFuncs GET api/Function1 - incoming request on worker tracked by ASP.NET Core and OTel instrumentation on the worker
- THIS IS A TEST generated within Function1 execution. It's a child of the incoming request to host - this is the problem

What I expect

GET - incoming HTTP request to host
- GET - outgoing HTTP request from host to worker
  - TestFuncs GET api/Function1 - incoming request on worker tracked by ASP.NET Core and OTel instrumentation on the worker
  - THIS IS A TEST generated within Function1 execution. It's a child of the incoming request to worker

Steps to reproduce

Run aspire dashboard docker run --rm -p 18888:18888 -p 4317:18889 -p 4318:18890 --name aspire-dashboard mcr.microsoft.com/dotnet/nightly/aspire-dashboard:latest
Run https://github.com/lmolkova/testfuncotel/tree/aspnetcoreint locally

jviau commented 2 days ago

Are you using AspNetCore integration here?

lmolkova commented 2 days ago

Yes, it's configured in ConfigureFunctionsWebApplication()

jviau commented 2 days ago

This is a known issue we are working on for AspNetCore integration. We have AspNetCore and Functions pipelines both creating their own activity to track this work and those two pipelines are disjointed, causing the correlation issue.

lmolkova commented 2 days ago

Awesome, feel free to close if it's a duplicate

Azure / azure-functions-dotnet-worker