Wiki is out of date and needs to be updated.

Azure / azure-functions-dotnet-worker

Azure Functions out-of-process .NET language worker

MIT License

423 stars 182 forks source link

Wiki is out of date and needs to be updated. #575

Open kinetiq opened 3 years ago

kinetiq commented 3 years ago

This link in particular:

https://github.com/Azure/azure-functions-dotnet-worker/wiki/.NET-Worker-bindings

Does not include SendGrid or Warmup, maybe more.
The link to the sample app is broken, and the sample app does not actually include examples for all bindings.
I would also update the sample code. The 2nd example is out of date, it involves creating custom types to set up a timer trigger. It probably works, but is now confusing.
Small typo: "In the new model, we have change" ... That last word should be "changed"

Would have done a PR but alas, they are not available for wikis.

Hope that helps.

anthonychu commented 3 years ago

Thanks @kinetiq. Yes it's too bad that PRs don't work for wikis. Can you please share where you're seeing the timer issue? I think I've addressed the others.

kinetiq commented 3 years ago

Hmm, I'm not sure what I was talking about there now. My wires may have been crossed, around that time I was definitely removing custom timer types I made and using the ones that come out of the box now.

I do feel that these demos would greatly benefit from having one with complexity somewhere between "string" and "custom type". That must be what I was trying to say. Sorry about that.

alexangas commented 3 years ago

It looks like a sample for SendGrid is not there yet. I'd like to set subject and text from the code but not sure how this should work as there is no SendGridMessage type to return. FYI @anthonychu

sholman commented 1 year ago

It's fairly disappointing that the documentation and extension samples (link) still haven't been completed 15 months later.

.NET 7 is now released, and as of .NET 8, the isolated model is the only one available.

dylanmeivis commented 1 year ago

It looks like a sample for SendGrid is not there yet. I'd like to set subject and text from the code but not sure how this should work as there is no SendGridMessage type to return. FYI @anthonychu

@alexangas Not Sure if you fixed it by now, but I Created an PR with a sample to set the subject and text inside the code of your function.