search

Azure / azure-functions-durable-extension

Durable Task Framework extension for Azure Functions
MIT License
713 stars 267 forks source link

Eternal orchestration correlates tracing from every execution with every previous execution #2391

Open michaelelleby opened 1 year ago

michaelelleby commented 1 year ago

Description

A clear and concise description of what the bug is. Please make an effort to fill in all the sections below; the information will help us investigate your issue.

NOTE: JavaScript issues should be reported here: https://github.com/Azure/azure-functions-durable-js

When using Eternal orchestrations in C# we are seeing correlation between every activity in every execution of the orchestration, making the correlation useless as now every log entry is correlated to every other log entry ever made.

Expected behavior

A clear and concise description of what you expected to happen.

Log entries of an orchestration execution and activities started by that execution are correlated.

Actual behavior

A clear and concise description of what actually happened.

Log entries of every orchestration execution and activities started by every execution are correlated.

Relevant source code snippets

I have made a small project demonstrating the issue https://github.com/michaelelleby/DurableFunctionsEternalOrchestrationDistributedTracing The code is using the example provided at https://github.com/Azure/azure-functions-durable-extension/discussions/1788#discussioncomment-671121 to make Distributed Tracing possible at all in Durable Functions.

Known workarounds

Provide a description of any known workarounds you used.

None.

App Details

Screenshots

If applicable, add screenshots to help explain your problem.

If deployed to Azure

We have access to a lot of telemetry that can help with investigations. Please provide as much of the following information as you can to help us investigate!

If you don't want to share your Function App or storage account name GitHub, please at least share the orchestration instance ID. Otherwise it's extremely difficult to look up information.

bachuv commented 1 year ago

Hi @michaelelleby, thanks for opening the issue and adding a link to a sample project. I will try to reproduce the issue. Just to confirm, was this working for you on a previous version of Durable Functions? Thanks!

michaelelleby commented 1 year ago

Downgrading Microsoft.Azure.WebJobs.Extensions.DurableTask NuGet package to version 2.5.0 produces the same issue. So no, it did not work on a previous version of Durable Functions.

michaelelleby commented 1 year ago

@bachuv any progress on this issue?

czeslav87 commented 8 months ago

@bachuv I believe this was mentioned in couple of issues already. (eg. here https://github.com/Azure/azure-functions-durable-extension/issues/939#issuecomment-544295526)

It would be nice if we could reset correlation when calling ContinueAsNew.

cc @michaelelleby